Yes I agreed that we really don't know whether Charles has visited Diana's grave or not. But no matter whether the he did or not, it doesn't affect my answer to this question. My answer is it's good for Charles to visit.
First, I don't see any reason that he shouldn't, simply because they were not enemy.
Second, Diana died at an unexpected young age. I think her suddend death leaved a lot of unfinished thing, and a lot of regrets. There must be some words didn't say. For Charles and Diana, considering so many rifts, so many hurts had been done, there were a lot, especailly emotional stuffs should be repaired. Though whether Charles visits or not has no difference to Diana, but it would be quite different for Charles.
Third, for the good sake of the two princes. No doubt that the openning and bitter divorce of Charles and Diana had left scars in the two princes hearts. The reconciling of their parents, even though separated by life and death would heal the scars to some extents. And since when Diana died, her two children were still so young, isn't it sad to see these two little boys to visited mother's grave on their own?
The last reason, maybe the most important one, it's for the good sake of the country. Admit it or not, the war of Wales has set the country into two camps. There is a big rift there. And Charles is the critical figure who is able to seal the rift. Since he is going to the King of Britain, I think it's his responsibility to do that. By visiting Diana's grave, I think it will give the clearest message to the public that the war of Wales doesn't exist anymore.
I don't know other Diana's fan. If I know Charles did visit Diana's grave, my impression of him would be much better.